This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
cmake: remove outdated comments #17413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Only add c++11 flags and definitions after cuda compiling" is not true anymore
ChaiBapchya
reviewed
Jan 23, 2020
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS}") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x") | ||
| else() | ||
| if(MSVC) |
There was a problem hiding this comment.
previously it was added after cuda compiling
- why was it done before?
- why is it no longer needed?
Thanks
There was a problem hiding this comment.
I'm not sure why it was done before. @jermainewang added the comment and may be able to clarify.
There was a problem hiding this comment.
It's no longer needed as the build works fine without it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.